Use codecov to monitor code coverage #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Definitely not a fan of the comments - surely they can be disabled though |
|
Fine with me 👍 a bit more awareness about coverage will not do harm, though I don't think we should religiously strive for the magic 100%. |
|
Let's give it a try and see if we like it :) |
|
If you put comment: offat https://codecov.io/account/gh/josdejong/yaml I think it will stop codecov commenting. |
|
I've added that configuration, let's see if it makes a change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be nice to track the coverage of mathjs's tests.
Saying that I am not a fan of the comments codecov sometimes puts into pull requests so we should avoid those if possible.
What do you reckon?