Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expressions: objects can't be written multi-line #1328

Closed
jean-emmanuel opened this issue Nov 20, 2018 · 3 comments
Closed

Expressions: objects can't be written multi-line #1328

jean-emmanuel opened this issue Nov 20, 2018 · 3 comments
Labels
feature help wanted

Comments

@jean-emmanuel
Copy link
Contributor

Looks like the getTokenSkipNewLine function could be used here to allow multi-line objects. What do you think ?
@josdejong
Copy link
Owner

Wow, good point. Never realized that this isn't supported right now, it would be really useful to allow multi line inside objects.

Anyone interested in creating a PR to improve this?

GHolk added a commit to GHolk/mathjs that referenced this issue Dec 6, 2018
@GHolk
Fix object literal enable multiple lines (josdejong#1328)
66accc0 
* Allow object literal expression be multiple lines

* Add test for multiple lines object literal
josdejong pushed a commit that referenced this issue Dec 6, 2018
@GHolk @josdejong
Fix object literal enable multiple lines (#1328) (#1349)
2032a9d 
* Allow object literal expression be multiple lines

* Add test for multiple lines object literal
@josdejong
Copy link
Owner

This issue has been addressed by @GHolk, in v5.4.0 multi-line object contents can be used.

@jean-emmanuel
Copy link
Contributor Author

Cool thanks @GHolk !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josdejong @jean-emmanuel