From e37bacda366872e6dfd16a56f7a8ad344f1b1bc8 Mon Sep 17 00:00:00 2001
From: Jos de Jong <wjosdejong@gmail.com>
Date: Thu, 25 Apr 2024 08:18:53 +0200
Subject: [PATCH] chore: replace util functions `values` and `contains` with
 using native JS functions (see #3194)

---
 tools/entryGenerator.js | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/tools/entryGenerator.js b/tools/entryGenerator.js
index ae779d022e..bc63e4df4c 100644
--- a/tools/entryGenerator.js
+++ b/tools/entryGenerator.js
@@ -266,7 +266,7 @@ function generateDependenciesFiles ({ suffix, factories, entryFolder }) {
 function generateFunctionsFiles ({ suffix, factories, entryFolder }) {
   const braceOpen = '{' // a hack to be able to create a single brace open character in handlebars
 
-  const sortedFactories = sortFactories(values(factories))
+  const sortedFactories = sortFactories(Object.values(factories))
 
   // sort the factories, and split them in three groups:
   // - transform: the transform functions
@@ -281,9 +281,9 @@ function generateFunctionsFiles ({ suffix, factories, entryFolder }) {
       if (isTransform(factory)) {
         transformFactories.push(factory)
       } else if (
-        contains(factory.dependencies, 'math') ||
-        contains(factory.dependencies, 'mathWithTransform') ||
-        contains(factory.dependencies, 'classes') ||
+        factory.dependencies.includes('math') ||
+        factory.dependencies.includes( 'mathWithTransform') ||
+        factory.dependencies.includes( 'classes') ||
         isTransform(factory) ||
         factory.dependencies.some(dependency => {
           return impureFactories.find(f => f.fn === stripOptionalNotation(dependency))
@@ -533,14 +533,6 @@ function sortFactories (factories) {
   return sortedFactories
 }
 
-function values (object) {
-  return Object.keys(object).map(key => object[key])
-}
-
-function contains (array, item) {
-  return array.indexOf(item) !== -1
-}
-
 function isTransform (factory) {
   return (factory && factory.meta && factory.meta.isTransformFunction === true) || false
 }