Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map-based latitude/longitude value editor for geocoordinate data type #835

Open
kochizufan opened this issue Nov 1, 2019 · 8 comments

Comments

@kochizufan
Copy link

JSON editor is great, but it is difficult to maintain geographical value with just editing text function.
Would you please add map-based editing function for geographical value?

If you decide it, I'm not good for JSON editor source code, but I'm somehow map library and geographical knowledge expert, so I can support you.

Regards,
Kohei

@josdejong
Copy link
Owner

This is an interesting idea Kohei! Thanks.

This could be similar to the color picker: a small icon on the left which opens a popup with a map with marker, where you can see and change the marker location.

What location data formats do you have in mind? [long, lat], {longitude, latitude}, GeoJSON point?

More broadly thinking: we could look into support for GeoJSON objects in general (points, polygons, rectangles, etcetera) similar to http://geojson.io.

There may be issues with selecting a free tile layer, this often is paid. So I think that should be customizable. We could look into leaflet+openstreatmap for example. Do you have ideas?

@kochizufan
Copy link
Author

Hi Jos,
Thank you for having interest in my proposal.

What location data formats do you have in mind? [long, lat], {longitude, latitude}, GeoJSON point?

I think it's better to allow users to register their own templates.

More broadly thinking: we could look into support for GeoJSON objects in general (points, polygons, rectangles, etcetera) similar to http://geojson.io.

I agree.

There may be issues with selecting a free tile layer, this often is paid. So I think that should be customizable. We could look into leaflet+openstreatmap for example. Do you have ideas?

Yes, that is my another point.
OSM is a good base map for a worldwide use case, but sometimes it is not suitable for precise use.
In such a case, the user may want to use another tile, so changing tile source function is important.

And about implementation, leaflet is OK for light casual use, but for future, now that tilemaps are starting to switch from rasters to vectors, leaflet won't be able to handle them in the vector-centric age.
So if considering the far future, mapbox gl js is the best selection.

@josdejong
Copy link
Owner

Sounds good 👍

Anyone interested in implementing this? (Before starting I think it's good to discuss the technical details)

@kochizufan
Copy link
Author

kochizufan commented Nov 6, 2019

If someone make this part,

a small icon on the left which opens a popup

then I can do this part

with a map with marker, where you can see and change the marker location.

@josdejong
Copy link
Owner

@kochizufan thanks for your offer, If you like we can work together on a PR.

@josdejong
Copy link
Owner

I think we have to have a look how to integrate a map solution: embedding a large map library just for this specific case may be overkill, we have to think that through.

@kochizufan
Copy link
Author

Are there any plugin-like structure?

@josdejong
Copy link
Owner

Not yet, but this may be a good reason to start it :) Related: #738, #819.

Let's first see if it's indeed an issue to bundle a map library, it's just an assumption on my side that it will be large.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants