Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContextMenu display issues #440

Closed
dhughes-xumak opened this issue Jul 18, 2017 · 3 comments
Closed

ContextMenu display issues #440

dhughes-xumak opened this issue Jul 18, 2017 · 3 comments

Comments

@dhughes-xumak
Copy link
Contributor

Noticed while working on fbd082d

Sometimes ContextMenu items with submenus do not display correctly (the arrow is not a separate element from the rest of the button). When this happens, the submenuTitle is not displayable; the parent menu item's title displays instead. This may also trigger the parent's click handler when trying to open the submenu. The overflow behaviour for the menu items could also be improved, so the last button in this example looks better.
image

These are probably trivial CSS changes, but I'm not even going to try fixing them. Hopefully somebody else could help fix these display issues.

@josdejong
Copy link
Owner

Thanks, let's address this whilst working out #438. I will have a look into it too (probably this weekend).

@dhughes-xumak
Copy link
Contributor Author

I revisited this and realized that the difference was intentional.

Type has no click handler, so the entire button can be used to expand the submenu.
Sort has a click handler on the top-level button, so a second button is added for expanding the submenu.

Consequently, I am going to close this issue as invalid. The text overflow wasn't an issue until #438 introduced custom context menu items, so it can be dealt with in that PR.

@josdejong
Copy link
Owner

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants