Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling size #1590

Closed
AbdulTheActivePiecer opened this issue Apr 28, 2024 · 6 comments
Closed

Bundling size #1590

AbdulTheActivePiecer opened this issue Apr 28, 2024 · 6 comments

Comments

@AbdulTheActivePiecer
Copy link

Hello there guys, much respect for the effort and dedication put into this project :D

This is more of a question than an issue, basically I only need the view mode of the jsonEditor and therefore don't really need ajv or Ace, so is there a way to have the package without these two dependencies to lower the bundle size ?

@josdejong
Copy link
Owner

@AbdulTheActivePiecer
Copy link
Author

AbdulTheActivePiecer commented Apr 29, 2024

Will do, thanks a lot.

just wondering, maybe I should open this as another issue but I am not sure if it is worth it, in "preview" mode when a value is wrapped or takes multiple lines, the key gets wrapped as well even though it shouldn't like in here (notice the "type" key) :
image
image
Is there anything I can configure to stop that from happening ?

@josdejong
Copy link
Owner

hmm. You can try fiddling some CSS to making the whitespace non breaking.

@AbdulTheActivePiecer
Copy link
Author

Thanks a lot man, much appreciated, was wondering if I can add a way to make link values configurable, like adding rel attribute and target to make them open in new windows.

@josdejong
Copy link
Owner

That will require changing the source code.

In the successor of this library, svelte-jsoneditor, things like that are possible: it has an option to customize how values are rendered via onRenderValue.

@AbdulTheActivePiecer
Copy link
Author

Thanks a lot @josdejong 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants