Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons feature request #1551

Open
sgurin opened this issue Sep 18, 2023 · 1 comment
Open

Icons feature request #1551

sgurin opened this issue Sep 18, 2023 · 1 comment
Labels

Comments

@sgurin
Copy link

sgurin commented Sep 18, 2023

Hi.

Plugin uses old image sprite technique that has lots of flexibility blockers. For example, if you want to change colors for icons you need to change SVG sprite. Also, issues because of sprite URL #675

image

I think icons could be develop using inline SVG icons approach https://css-tricks.com/cascading-svg-fill-color/

It would be more flexible, accessible and you will remove link to sprint from CSS that is point on lots issues

@josdejong
Copy link
Owner

Thanks for your suggestion. Using a sprite is indeed limiting. The successor of this library, svelte-jsoneditor uses FontAwesome SVG's, that works like a charm.

I'm not planning on replacing the sprite icons myself for jsoneditor, but help would be welcome. Anyone interested in picking this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants