Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use noreferrer for window.open #1365

Merged
merged 1 commit into from Aug 25, 2021
Merged

Use noreferrer for window.open #1365

merged 1 commit into from Aug 25, 2021

Conversation

rajitbanerjee
Copy link
Contributor

Notes

  • Using noopener without noreferrer is a security risk with a threat of Reverse Tabnabbing.
  • Changing the flag to noreferrer which automatically sets noopener as well.

Testing

  • No linting issues and all tests pass.

@josdejong
Copy link
Owner

Thanks Rajit 👍

I didn't know noreferrer automatically sets noopener, that is nice and clean

@josdejong josdejong merged commit ed09d87 into josdejong:develop Aug 25, 2021
@josdejong
Copy link
Owner

Fix published in v9.5.4

@josdejong
Copy link
Owner

thanks again 😄

andyquinterom pushed a commit to proyais/jsoneditor that referenced this pull request Dec 7, 2021
@andyquinterom
Use noreferrer for window.open (josdejong#1365)
084b371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rajitbanerjee @josdejong