Disable mode drop down if contnents are invalid json

[yogeshmahajan-1903]

Steps to reproduce -
1.Enter valid json content.
2.Delete some semicolon in order to create invalid json.
3.Try to change mode.
4.Console shows error.

Expected - Mode drop down should be disabled if contents are invalid json

[yogeshmahajan-1903]

I think not only mode drop but also all operation buttons should be disabled except 'Repair Json'

[josdejong]

In text mode, when the text contents is no valid, parsable JSON, various features cannot be executed: expand, collapse, switch to tree mode, ...

When you try to execute those actions, an error will be thrown. By default, this error is logged in the console only. You can catch the error yourself and do something alternative, like presenting the error to the user in a modal or something like that:

const options = {
  onError: function (err) {
      alert(err.toString())
    }
}

Thinking about it, it may be better default behavior to show such a basic alert to the user on error instead of logging in the console.

In general I try to be careful with disabling buttons: it's easily not clear for a user why a button is disabled and what the user needs to do to get it enabled, so showing an explanatory error to the user when an action cannot be performed has my preference.

[josdejong]

I've changed the default behavior to open a basic alert when an error occurs, see cbb95ae

[yogeshmahajan-1903]

Showing error will be more useful.
I have used onError(), but this works only for format & compact json buttons in Code mode.
For other buttons like transform, sort (in cod emode) still error is logged to console.

[josdejong]

For other buttons like transform, sort (in cod emode) still error is logged to console.

Hm, that should not be the case. I'll double check it

[josdejong]

You're right. I'll fix that.

[yogeshmahajan-1903]

Thanks :)

[josdejong]

Fixed via b3b31f2 (not yet published)

[josdejong]

Fixes/improvements are published now in v9.5.4

[yogeshmahajan-1903]

Now error is shown in alert box instead of console.