Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.jsoneditor .jsoneditor-tree background is transparent #1356

Closed
ChrisAcrobat opened this issue Jul 24, 2021 · 3 comments
Closed

.jsoneditor .jsoneditor-tree background is transparent #1356

ChrisAcrobat opened this issue Jul 24, 2021 · 3 comments
Labels

Comments

@ChrisAcrobat
Copy link

ChrisAcrobat commented Jul 24, 2021

Style of .ace_content defaults to white #fff, but none it set for .jsoneditor-tree. This make .jsoneditor-tree hard to read when background is dark or black. I have solved it locally, so I just letting you know. I tried to take a look, but I not that familiar with SCSS just yet to make a PR.

Current values in browser

.jsoneditor .ace_content {
	background-color: #fff;
}
.jsoneditor .jsoneditor-tree {
	background-color: initialt; /* not set/no value */
}
@ChrisAcrobat
Copy link
Author

Somewhat related to #1295.

@josdejong
Copy link
Owner

Ah, you're right, we should give the tree mode a white background instead of transparent. I'll fix that.

@josdejong
Copy link
Owner

The fix is now published in v9.5.3

andyquinterom pushed a commit to proyais/jsoneditor that referenced this issue Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants