Fixed relative URLs from becoming absolute during build #1354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the generated absolute image URLs mentioned in #675. The
gulp-concat-css
build would previously convert the paths in thedist
folder to be relative. However, disabling therebaseUrls
option (which defaults to true) will prevent the URLs from being changed (gulp-concat-css API).Additionally,
gulp-clean-css
would still rebase the URLs with the above change, so a similar option had to disabled there too for relative URLs in the.min.css
file (gulp-clean-css options).Example of a relative URL in the
dist/jsoneditor.css
file:If there is anything else I should add please let me know!