Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of dumb terminals on Windows #91

Merged
merged 1 commit into from Jun 3, 2022

Conversation

MartinKolarik
Copy link
Contributor

The default Windows terminal doesn't set env.TERM so we cannot require the variable to be set like on other platforms but if it is set, we should use it because there are many third-party terminals, particularly those embedded in various GUI apps, that don't support colors and correctly set this variable. Fixes #90.

Precommit checks in GitHub Desktop app (before):

image

After:

image

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022

Codecov Report

Merging #91 (3a63878) into main (840f50e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          145       146    +1     
=========================================
+ Hits           145       146    +1     
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 840f50e...3a63878. Read the comment docs.

@kibertoad kibertoad merged commit 1674926 into jorgebucaran:main Jun 3, 2022
@kibertoad
Copy link
Collaborator

Thank you!

@jorgebucaran
Copy link
Owner

Thank you, @MartinKolarik, @kibertoad! 🙌

@jorgebucaran jorgebucaran added the bug Something isn't working label Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong support detection on Windows
4 participants