Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

Add env to options in index.d.ts #118

Merged
merged 3 commits into from Apr 29, 2020
Merged

Add env to options in index.d.ts #118

merged 3 commits into from Apr 29, 2020

Conversation

filipbudisa
Copy link
Contributor

@filipbudisa filipbudisa commented Dec 18, 2019

Fixes #117

This PR introduces 4 changes to the exec function typescript definition, making it compliant with the javascript code.

  • Makes parameters options and callback optional
  • If only 2 parameters are passed to exec, the second parameter is the callback function
  • Adds the optional env field to options
  • Allows callback stdout and stderr fields to be Buffers

@filipbudisa
Copy link
Contributor Author

0ae7ed8 allows exec to be called with only 1 or 2 parameters, allowing the second parameter to be the callback. Also fixed callback parameter types.

@filipbudisa
Copy link
Contributor Author

@jorangreef any chance of this getting merged?

@jorangreef jorangreef merged commit 9a6ced4 into jorangreef:master Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS: Object literal may only specify known properties
2 participants