This repository has been archived by the owner on Sep 23, 2021. It is now read-only.
Add TypeScript typings file #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jorangreef ping |
|
Thanks @bpasero! |
|
@jorangreef thanks, can you publish a minor new release so that VSCode can consume? |
|
Done! |
|
Thanks, can you publish to NPM too?
|
|
Sorry about that @bpasero, I did but didn't see that the publish failed. I have redone it now. |
|
@jorangreef is it possible that some npmignore excludes it? I do not see the file:
|
|
Good catch. The package files whitelist also needed to be updated. A patch version to fix this has just been published to NPM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows VSCode to remove our
sudo-prompt.d.tsin our repo.Refs: microsoft/vscode#83421