Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Fix for Prototype Pollution #33

Conversation

ready-research
Copy link
Contributor

@ready-research ready-research commented Sep 4, 2021

Fix prototype pollution when path components are not strings
Reported in https://www.huntr.dev/bounties/2eae1159-01de-4f82-a177-7478a408c4a2/

Can you please validate this huntr report?

Fix prototype pollution when path components are not strings
@jonschlinkert
Copy link
Owner

Great catch. thank you! we'll issue a patch ASAP. sorry this escaped my radar, ideally I'd be spending all of my time on open source but I can't yet.

@jonschlinkert jonschlinkert merged commit b057b1b into jonschlinkert:master Sep 12, 2021
jonschlinkert added a commit that referenced this pull request Sep 12, 2021
Fixes #33 thanks to @ready-research.
@benjifin
Copy link

Hey @jonschlinkert and @ready-research note that we at Snyk have already disclosed this vulnerability and assigned it CVE-2021-23435.

This vulnerability was originally disclosed as part of our team's research into type confusion vulnerabilities which is why we have gone ahead and assigned it the CVE we reserved for it - despite this we have been happy to credit ready-research as well as our team member's as part of it's discovery in our advisory: https://snyk.io/vuln/SNYK-JS-SETVALUE-1540541 and link to all relevant info including the huntr advisory in the CVE issued.

@JamieSlome
Copy link

@benjifin - we have stopped the CVE assignment process and have now referenced the existing CVE against our report.

Cheers! 🎉

@ready-research
Copy link
Contributor Author

@jonschlinkert Can you please confirm the fix in huntr. So that we can disclose this report publicly. Thank you.

@jonschlinkert
Copy link
Owner

jonschlinkert commented Sep 13, 2021 via email

@ready-research
Copy link
Contributor Author

Sorry for the inconvenience caused to you.
It is the application policy to disclose publicly only when it is confirmed with fix by the maintainer. That is the reason I reminded you multiple times. I will not remind it again and really sorry for bothering you again.

@afdev82
Copy link

afdev82 commented Oct 4, 2021

Would you mind to backport the patch?
I could provide a PR if you are willing to bump a v2.0.2 with it.
Many packages, dependencies of @rails/webpacker / webpack are using the v2.0.1.
Thank you for your support!

@1dsb
Copy link

1dsb commented Oct 5, 2021

Can I add my support for a backport to version 2 as well. Angular 10 (still in support) uses the version of webpack that in turn uses set-value V2.
Thanks.

@joeyJsonar
Copy link

Any updates on the backport? The reason I can't just jump to 4.0.1 from 3.0.1 is that I need to upgrade 1 major version on node, from 10 to 11, which is very risky atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants