Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xctrace support #286

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

xctrace support #286

wants to merge 1 commit into from

Conversation

ldm0
Copy link

@ldm0 ldm0 commented Mar 26, 2023

Basically working. Required to be done:

Fixes #246

@ldm0 ldm0 marked this pull request as draft March 26, 2023 17:59
Cargo.toml Outdated Show resolved Hide resolved
@ldm0 ldm0 force-pushed the ldm_xctrace_support branch 4 times, most recently from 8988028 to 4fdfd61 Compare April 2, 2023 09:21
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Patch coverage is 84.70% of modified lines.

Files Changed Coverage
src/collapse/mod.rs ø
src/collapse/xctrace.rs 84.58%
src/collapse/guess.rs 100.00%

📢 Thoughts on this report? Let us know!.

@kraktus
Copy link

kraktus commented Apr 16, 2023

Hey, I was going to start working on integrating this only to see the work was already done! Thanks @ldm0!

I can help add the documentation if needed. Also not sure if this feature need to be tied to the quick-xml update?

@ldm0
Copy link
Author

ldm0 commented Apr 16, 2023

I can help add the documentation if needed. Also not sure if this feature need to be tied to the quick-xml update?

Thanks! I've written some documentation already, will submit it tomorrow. I think introducing multiple versions of the same dependency is bad(in terms of artifact size and complexity), so I'm waiting for the quick-xml update.

BTW, I've forked flamegraph with this inferno branch and you can try it: cargo install --git https://github.com/ldm0/flamegraph --branch xctrace, I replaced the default tracer(dtrace) with xctrace on macOS. (Make sure you get an XCode>=14.3 though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use xctrace on macOS
3 participants