Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tokio 1.0 #114

Closed
MonsieurMan opened this issue Dec 21, 2020 · 8 comments · Fixed by #118
Closed

Update to tokio 1.0 #114

MonsieurMan opened this issue Dec 21, 2020 · 8 comments · Fixed by #118

Comments

@MonsieurMan
Copy link

Hi there !

I'll be using your library for a little raspberry project, checking tokyo I see there is a new version.

I'm in need of a little more training in Rust, would you be interested in me landing a PR for a migration to tokyo 0.3, or are there any current work on the matter ?

Thanks in advance,

@jonhoo
Copy link
Owner

jonhoo commented Dec 22, 2020

Hi! Absolutely, I'd love one. I think we're probably going to be blocked on hyper not yet supporting tokio 0.3, but getting the ball rolling is a good idea :)

@MonsieurMan
Copy link
Author

MonsieurMan commented Dec 22, 2020

hyper author is going to wait a few weeks for tokio 1.0 to ship, in order not to burden his users with potentially two breaking releases.
So you're right, I can do some preparation work, but it won't be finished until tokio 1.0 and hyper 0.14

@jonhoo
Copy link
Owner

jonhoo commented Dec 25, 2020

Now that tokio 1.0 and hyper 0.14 are out, I think we're only blocked on hyper-tls to get this out the door (hyperium/hyper-tls#76)!

@jonhoo
Copy link
Owner

jonhoo commented Dec 25, 2020

@nc7s
Copy link

nc7s commented Dec 29, 2020

And tokio 1.0 was released. What a pace for them.

@jonhoo jonhoo changed the title Migration to tokyo 0.3 Update to tokio 1.0 Dec 29, 2020
@jonhoo jonhoo pinned this issue Dec 29, 2020
@peppizza
Copy link

peppizza commented Jan 5, 2021

hyper-tls v0.5 has been released with tokio 1.0, so if that was the last thing blocking then we should be free to update this lib

@jonhoo
Copy link
Owner

jonhoo commented Jan 6, 2021

We unfortunately also currently have warp as a dev-dependency, which is still on tokio 0.2 (issue here: seanmonstar/warp#725). If someone wants to submit a PR that moves the tests to use hyper for the server instead (shouldn't be too painful), then that would unblock the move!

jonhoo added a commit that referenced this issue Jan 9, 2021
We still end up with an unused transitive dependency on tokio 0.2
through `webdriver`. Upstream has a pending fix for that in
https://bugzilla.mozilla.org/show_bug.cgi?id=1684226, but this is still
worthwhile to get out the door.

Fixes #114.
@jonhoo
Copy link
Owner

jonhoo commented Jan 9, 2021

#118

@jonhoo jonhoo unpinned this issue Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants