Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete removal of flutter_native_splash #683

Open
PJPAC opened this issue Mar 29, 2024 · 2 comments
Open

Incomplete removal of flutter_native_splash #683

PJPAC opened this issue Mar 29, 2024 · 2 comments

Comments

@PJPAC
Copy link

PJPAC commented Mar 29, 2024

Hi,
I've been facing a side issue (get-it, BlocProvider and asynchronous registration leading to some classes not being "on time" registered), and with the aim of solving it, I have then been trying, with my limited understanding and experience, to allow for more resources to be allocated to singleton registration.
For this reason, I have tried to uninstall flutter_native_splash from my project, and I failed. Any suggestion would be helpful.

Best Wishes

Describe the bug
I've followed the command
flutter pub run flutter_native_splash:remove
First after having altered the pubspec.yaml file, and then after having realised it was both not working and a bit silly to have removed the reference to the dependency in the pubspec.yaml file,

  • I reinstated flutter_native_splash in pubspec.yaml
  • I implemented the commands
    flutter pub run flutter_native_splash:remove
    flutter clean
  • I commented flutter_native_splash in pubspec.yaml and commented all the related code in the app
  • I implemented the command
    flutter pub get
  • I turned off the IDE and the computer before restarting them both...
  • I implemented the command
    flutter pub get
    ... but the splashscreen is still well alive.

Initially, I thought that I could remove the png file but then if the splashscreen were not show up any more, it would not mean that something is still not running in the background which would defeat the purpose of my efforts.
To ;y surprise, when I have removed the png file from the assets, flutter clean, flutter pub get, restart the IDE, ... the splashscreen was still well alive.

Using Android Studio, and searching for the word "splash", it popped up as

in launch_background.xm files located in
android/app/src/main/res/drawable-night-v21
android/app/src/main/res/drawable-night
android/app/src/main/res/drawable-v21
android/app/src/main/res/drawable
Similarly, there are references to a splash screen in styles.xml files located in
android/app/src/main/res/values
android/app/src/main/res/values-night
... etc.
That said, I am wary of playing with these files as I would not really understand what I'd be doing...

I've noticed jantheok comment on the issue #553 but "reenable my platforms (by writting e.g. "Enable android for this project" in the command center" is unclear to me, especially "command center".

** A clear and concise description of what the bug is.
The removal of flutter_native_splash as implemented through
flutter pub run flutter_native_splash:remove
and subsequent operations does not seem complete. Are there bits of codes somewhere which should be removed/edited ?

Configuration
Android Studio Hedgehog | 2023.1.1 Patch 2
Flutter version 3.19.4
Dart version 3.3.2
DevTools version 2.31.1
Platform android-34, build-tools 34.0.0

** I use flutter_native_splash: ^2.4.0

** Device (please complete the following information):**

  • Device: Samsung Galaxy A70
  • OS: android 11

** To Reproduce**
Steps to reproduce the behavior are given above.

Screenshots
na

Additional context
na

@jonbhanson
Copy link
Owner

Flutter comes with a blank white native splash screen. It cannot be removed. This package allows you to configure the splash screen. If you run the art run flutter_native_splash:remove command, it simply removes any customization that the package has made and restores the white splash screen.

If you are trying to free resources, removing this package will not help. This package does not consume any resources in your app beyond the storage space of any images that you have added.

@PJPAC
Copy link
Author

PJPAC commented Apr 15, 2024

Hi,
Many thanks for the feedback. I take not for the resources.

I've rerun dart run flutter_native_splash:remove, after having reinstated flutter_native_splash in the dependencies + pub get, and before having commented it back + pub get... the previous splash screen still shows up at the start of the app.
At the end of the day, it is not that annoying but it is puzzling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants