Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplashScreenAnimated support #475

Open
FabienZE opened this issue Dec 13, 2022 · 2 comments
Open

SplashScreenAnimated support #475

FabienZE opened this issue Dec 13, 2022 · 2 comments
Labels
feature request New feature or request

Comments

@FabienZE
Copy link

Please support the full new Android 12 Splashscreen API
with these 2 attributes :

<item name="windowSplashScreenAnimatedIcon">@mipmap/ic_launcher_round</item>
<item name="windowSplashScreenAnimationDuration">300</item>

as it is documented on Google Docs :
https://developer.android.com/develop/ui/views/launch/splash-screen#implement

@jonbhanson jonbhanson added the feature request New feature or request label Jan 16, 2023
@shatanikmahanty
Copy link

shatanikmahanty commented Feb 25, 2023

@jonbhanson may I work on this? I have a working code using the example starter kit provided in official android sample. Would try to integrate that then!

Changes estimated to be required by user:

  • Need to set min android sdk constraint 21 for the android dependency required to work properly. User also needs to use the above mentioned library in android build.gradle

  • Need to set two parameters in pubspec.yaml config corresponding to the required parameters mentioned by @FabienZE for the library to add values in style.xml

Design doubts:

  • Should the AVD file be used directly from android drawable folder or from assets folder in project root where pubspec exists?
  • Should we use a default duration in case user doesnot specify the duration or we should show error in that case?
  • Expected behaviour for Android 12 and above: When both AVD and image are provided. Should we show warning that android will directly use animated icon and ignore the splash icon vector, or we should let it be?

@jonbhanson
Copy link
Owner

@shatanikmahanty anybody can add features. As long as some in the community want the feature and the code quality is high, the PR will be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants