Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Theme.MaterialComponents #467

Open
sirwes opened this issue Dec 7, 2022 · 4 comments
Open

Use Theme.MaterialComponents #467

sirwes opened this issue Dec 7, 2022 · 4 comments
Labels
feature request New feature or request

Comments

@sirwes
Copy link

sirwes commented Dec 7, 2022

I use Stripe in my application, which requires using Theme.MaterialComponents instead of @android:style/Theme.Black.NoTitleBar in my styles.xml files

Could you add an option to use generate the files using Theme.MaterialComponents instead? It's literally a one line swap in each of the styles.xml files
from
<style name="NormalTheme" parent="@android:style/Theme.Black.NoTitleBar">
to
<style name="NormalTheme" parent="Theme.MaterialComponents">

Reference:
https://github.com/flutter-stripe/flutter_stripe#android
https://github.com/flutter-stripe/flutter_stripe/blob/main/example/android/app/src/main/res/values/styles.xml#L15

@jonbhanson
Copy link
Owner

I am hesitant to add a feature for a single use case. Other users of this package: please give @sirwes' request above a thumbs up if you also need this feature.

@jonbhanson jonbhanson added the feature request New feature or request label Dec 18, 2022
@sirwes
Copy link
Author

sirwes commented Feb 2, 2023

Could you add a flag that would do one or the other depending on your setup?

@HE-LU
Copy link

HE-LU commented Nov 13, 2023

I'm having the same issue with Stripe now... I had to go and change it everywhere manually...

Edit: It makes me think that the AppCompat is outdated, this is probably smth that should be fixed on a Stripe end.

@tobia80
Copy link

tobia80 commented Mar 2, 2024

Same here with Stripe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants