Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't this be a dev_dependencies? #431

Closed
tobiasht opened this issue Oct 5, 2022 · 2 comments
Closed

Shouldn't this be a dev_dependencies? #431

tobiasht opened this issue Oct 5, 2022 · 2 comments

Comments

@tobiasht
Copy link

tobiasht commented Oct 5, 2022

Shouldn't this be a dev_dependencies and not a dependencies?

I thought all the files were generated when you run flutter pub run flutter_native_splash:create. So there should be no need to compile the package along with the app.

@tobiasht
Copy link
Author

tobiasht commented Oct 6, 2022

I found the reason for it in the ReadMe. But if you don't need the splash screen to remain open while your app initialises. You can still use it as a dev_dependencies, right? If that is the case, it should be made clearer in the usage section.

@jonbhanson
Copy link
Owner

I will make an update in the readme to clarify this point. However, it will still only be a small note at the bottom - developers often start with the most prominent example code and only the read the documentation if it does not work, so I want the default to work for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants