Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.html always gets additional lines added #430

Closed
Bungeefan opened this issue Oct 3, 2022 · 2 comments
Closed

index.html always gets additional lines added #430

Bungeefan opened this issue Oct 3, 2022 · 2 comments

Comments

@Bungeefan
Copy link
Contributor

Attention: If you open a bug report without sufficient details, it will be closed. Is your question
related to Android 12? Please check the notes on Android 12 first (https://pub.dev/packages/flutter_native_splash#android-12-support).

Describe the bug

Everytime the create task is executed, the package adds new lines to index.html. Even if there are already enough lines.

Configuration

Shouldn't need any configuration but if in doubt, see configuration from #429

To Reproduce
Steps to reproduce the behavior, using the example app:

  1. Set the config
  2. Run flutter pub run flutter_native_splash:create multiple times
  3. See index.html for new lines after the last picture tag.

Screenshots

Additional context

@jonbhanson
Copy link
Owner

Thanks for catching this. I will soon push an update that includes a fix.

@Bungeefan
Copy link
Contributor Author

Thanks for the quick fix!
Is it intenional that it still adds a single blank line after each create execution?

jonbhanson added a commit that referenced this issue Nov 6, 2022
Closes #447.

Additional fix for index.html getting extra blank lines. Fixes #430.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants