Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the JsonString smarter #487

Merged
merged 1 commit into from Jul 1, 2022
Merged

Make the JsonString smarter #487

merged 1 commit into from Jul 1, 2022

Conversation

jonasbb
Copy link
Owner

@jonasbb jonasbb commented Jul 1, 2022

This allow nested application of serde_as logic on the inner value.

// Rust
value: BTreeMap<[u8; 2], u32>,

// JSON
{"value":"[[\"[1,2]\",3],[\"[4,5]\",6]]"}

Closes #485

bors r+

This allow nested application of `serde_as` logic on the inner value.

```rust
// Rust
value: BTreeMap<[u8; 2], u32>,

// JSON
{"value":"[[\"[1,2]\",3],[\"[4,5]\",6]]"}
```
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #487 (69ed4a1) into master (6969abf) will decrease coverage by 0.02%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
- Coverage   70.79%   70.76%   -0.03%     
==========================================
  Files          52       52              
  Lines        3592     3599       +7     
==========================================
+ Hits         2543     2547       +4     
- Misses       1049     1052       +3     
Impacted Files Coverage Δ
serde_with/src/json.rs 50.00% <50.00%> (-13.64%) ⬇️
serde_with/tests/json.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6969abf...69ed4a1. Read the comment docs.

@bors
Copy link
Contributor

bors bot commented Jul 1, 2022

Build succeeded:

@bors bors bot merged commit 49ebe72 into master Jul 1, 2022
@bors bors bot deleted the better-jsonstring branch July 1, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend JsonString for transitive serde_as usage
1 participant