Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for IndexMap and IndexSet #436

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Add tests for IndexMap and IndexSet #436

merged 2 commits into from
Apr 19, 2022

Conversation

jonasbb
Copy link
Owner

@jonasbb jonasbb commented Apr 19, 2022

During the tests a missing implementation of DuplicateInsertsFirstWinsMap was noticed, but is now included.
indexmap was also missing the serde-1 feature flag.

bors merge

During the tests a missing implementation of `DuplicateInsertsFirstWinsMap`
was noticed, but is now included.
`indexmap` was also missing the `serde-1` feature flag.
bors bot added a commit that referenced this pull request Apr 19, 2022
436: Add tests for IndexMap and IndexSet r=jonasbb a=jonasbb

During the tests a missing implementation of `DuplicateInsertsFirstWinsMap` was noticed, but is now included.
`indexmap` was also missing the `serde-1` feature flag.

bors merge

Co-authored-by: Jonas Bushart <jonas@bushart.org>
@bors
Copy link
Contributor

bors bot commented Apr 19, 2022

Build failed:

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #436 (9196836) into master (a8bce82) will increase coverage by 0.91%.
The diff coverage is 96.82%.

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   70.06%   70.98%   +0.91%     
==========================================
  Files          51       52       +1     
  Lines        3404     3467      +63     
==========================================
+ Hits         2385     2461      +76     
+ Misses       1019     1006      -13     
Impacted Files Coverage Δ
serde_with/src/ser/impls.rs 93.75% <ø> (ø)
...e_with/src/duplicate_key_impls/first_value_wins.rs 57.14% <77.77%> (+7.14%) ⬆️
serde_with/src/de/impls.rs 72.88% <100.00%> (+0.23%) ⬆️
serde_with/tests/indexmap.rs 100.00% <100.00%> (ø)
...de_with/src/duplicate_key_impls/last_value_wins.rs 87.50% <0.00%> (+31.25%) ⬆️
...with/src/duplicate_key_impls/error_on_duplicate.rs 87.50% <0.00%> (+31.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8bce82...9196836. Read the comment docs.

@jonasbb
Copy link
Owner Author

jonasbb commented Apr 19, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 19, 2022

Build succeeded:

@bors bors bot merged commit 88ffa73 into master Apr 19, 2022
@bors bors bot deleted the indexmap-tests branch April 19, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant