Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong clippy warning #421

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Fix wrong clippy warning #421

merged 1 commit into from
Mar 21, 2022

Conversation

jonasbb
Copy link
Owner

@jonasbb jonasbb commented Mar 21, 2022

The new lint clippy::only_used_in_recursion is buggy when used in traits.
rust-lang/rust-clippy#8560

@jonasbb
Copy link
Owner Author

jonasbb commented Mar 21, 2022

bors merge

bors bot added a commit that referenced this pull request Mar 21, 2022
421: Fix wrong clippy warning r=jonasbb a=jonasbb

The new lint `clippy::only_used_in_recursion` is buggy when used in traits.
rust-lang/rust-clippy#8560

Co-authored-by: Jonas Bushart <jonas@bushart.org>
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #421 (d251b83) into master (b129b5a) will not change coverage.
The diff coverage is n/a.

❗ Current head d251b83 differs from pull request most recent head c94da71. Consider uploading reports for the commit c94da71 to get more accurate results

@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   70.37%   70.37%           
=======================================
  Files          51       51           
  Lines        3386     3386           
=======================================
  Hits         2383     2383           
  Misses       1003     1003           
Impacted Files Coverage Δ
serde_with/src/lib.rs 75.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b129b5a...c94da71. Read the comment docs.

The new lint `clippy::only_used_in_recursion` is buggy when used in traits.
rust-lang/rust-clippy#8560
@bors
Copy link
Contributor

bors bot commented Mar 21, 2022

Canceled.

@jonasbb
Copy link
Owner Author

jonasbb commented Mar 21, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 21, 2022

Build succeeded:

@bors bors bot merged commit e4681d5 into master Mar 21, 2022
@bors bors bot deleted the fix-clippy branch March 21, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant