Allow generics for SerializeDisplay and DeserializeFromStr derives
#413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
==========================================
- Coverage 70.85% 70.37% -0.49%
==========================================
Files 51 51
Lines 3363 3386 +23
==========================================
Hits 2383 2383
- Misses 980 1003 +23
Continue to review full report at Codecov.
|
The derives did not take into account that types can have generics. Ensure that lifetime and type generics are added to the generated impls. Add new tests to `serde_with_test` to prevent regressions.
jonasbb
force-pushed
the
fix-derive-generics
branch
from
778c310
to
ddb06e1
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The derives did not take into account that types can have generics. Ensure that lifetime and type generics are added to the generated impls. Add new tests to
serde_with_testto prevent regressions.