Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

Responder should shut down after connection terminates #70

Open
jonas-schievink opened this issue Aug 7, 2019 · 1 comment
Open

Responder should shut down after connection terminates #70

jonas-schievink opened this issue Aug 7, 2019 · 1 comment
Labels
area: link layer Code Area: BLE Link Layer (establishing and maintaining connections, encryption, etc) status: needs code An implementation or a bugfix need to be written type: bug Something isn't behaving as intended

Comments

@jonas-schievink
Copy link
Owner

Right now, when the link-layer connection is terminated, the packet queues might still contain data the responder will then still try to process. This might even "succeed" until the sending queue fills up. We should try to clear the queues and signal that the connection has shut down.

@jonas-schievink jonas-schievink added type: bug Something isn't behaving as intended status: needs code An implementation or a bugfix need to be written area: link layer Code Area: BLE Link Layer (establishing and maintaining connections, encryption, etc) labels Aug 7, 2019
@jonas-schievink
Copy link
Owner Author

jonas-schievink commented Aug 17, 2019

Looks like I thought about this in #26 already, but never implemented it:

For LL_TERMINATE_IND I think we'll want to quit the connection state and send the PDU through the channel, allowing the non-realtime part to later invoke a user callback.

This is not enough though, since the termination PDU will not be processed if the tx queue is full.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: link layer Code Area: BLE Link Layer (establishing and maintaining connections, encryption, etc) status: needs code An implementation or a bugfix need to be written type: bug Something isn't behaving as intended
Projects
None yet
Development

No branches or pull requests

1 participant