Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ios and android to user_agent provider #985

Merged
merged 6 commits into from Aug 7, 2019
Merged

add ios and android to user_agent provider #985

merged 6 commits into from Aug 7, 2019

Conversation

gsilvan
Copy link
Contributor

@gsilvan gsilvan commented Aug 6, 2019

Update to user_agent provider

This update adds Android and iOS user agent to Firefox and Chrome as requested in #935 .
There is also a small bug fixed in randomization of WebKit's version number where a dot was missing (50b4073)

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests for android_platform_token and ios_platform_token?

faker/providers/user_agent/__init__.py Outdated Show resolved Hide resolved
@fcurella
Copy link
Collaborator

fcurella commented Aug 7, 2019

Thank you ✨

@fcurella fcurella merged commit d7501e2 into joke2k:master Aug 7, 2019
@gsilvan gsilvan deleted the mobile-useragent branch May 27, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants