Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique profile #1817

Open
azmeuk opened this issue Mar 9, 2023 · 11 comments
Open

Unique profile #1817

azmeuk opened this issue Mar 9, 2023 · 11 comments

Comments

@azmeuk
Copy link

azmeuk commented Mar 9, 2023

  • Faker version: 17.4.0
  • OS: Archlinux

Data unicity and profile are two great faker features, bun unfortunately they don't fit well together:

>>> import faker
>>> fake = faker.Faker()
>>> fake.unique.profile()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File ".../site-packages/faker/proxy.py", line 314, in wrapper
    if retval not in generated:
TypeError: unhashable type: 'dict'

I suggest implementing unique profile generation, where each value in the profile would be unique.

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jun 8, 2023
@azmeuk
Copy link
Author

azmeuk commented Jun 11, 2023

Please stale bot, let this ticket open.

@github-actions github-actions bot removed the stale label Jun 12, 2023
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Sep 11, 2023
@azmeuk
Copy link
Author

azmeuk commented Sep 11, 2023

This issue is still relevant.

@github-actions github-actions bot removed the stale label Sep 12, 2023
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Dec 11, 2023
@azmeuk
Copy link
Author

azmeuk commented Dec 11, 2023

I still don't agree 😮‍💨

@stefan6419846
Copy link
Contributor

Feel free to submit a corresponding PR.

@azmeuk
Copy link
Author

azmeuk commented Dec 11, 2023

Yes I know that :) But in the meantime there is no reason to close the ticket.

@stefan6419846
Copy link
Contributor

I personally do not like the stale bot stuff either, especially with low activity on maintainer tagging, but I am just a contributor here as well and not going to blame anyone for using it - there usually are perfectly valid reasons to introduce such bots.

@github-actions github-actions bot removed the stale label Dec 12, 2023
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Mar 12, 2024
@azmeuk
Copy link
Author

azmeuk commented Mar 12, 2024

I still wish to keep the ticket open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants