Fix IT SSN generation with latin chars in name or surname #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcurella
requested changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Fix IT SSN generation when Person provider returns first or last name with latin chars
What was wrong
Latin chars was considered neither vowel nor consonant. They just got ignored, and the resulting SSN was wrong, or even shorter than expected length (16 chars) in case of short names/surnames.
How this fixes it
This change applies a transliteration for dyacritic chars, translating them into the equivalents ASCII chars, according to the Italian SSN generation rules.
Fixes #1757