Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1656
What does this change
This removes re-seeding the
Random()
instance on every call to_select_factory()
which gets called every time a faker method is used. This code was only reached when both conditions are true:Faker.seed()
What was wrong
Basically same as above, it is unnecessary to set the
Random()
instance's seed value every time a faker method is used. TheRandom()
instance is seeded when making the call toFaker.seed()
which is sufficient for making sure that the order of the locales selected is the same between subsequent instances ofFaker
How this fixes it
Remove the seeding that isn't needed and modified a test that asserts:
Faker.seed()
and using aFaker
instance in an identical way will produce the same fake output each timeFixes #...