Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing number in SHA-256 docstring and add hyphen for SHA hashes #1751

Merged
merged 1 commit into from Nov 21, 2022
Merged

Add missing number in SHA-256 docstring and add hyphen for SHA hashes #1751

merged 1 commit into from Nov 21, 2022

Conversation

gustavi
Copy link
Contributor

@gustavi gustavi commented Nov 18, 2022

What does this change

  • Small typo: SHA56 => SHA256
  • Rename SHA<N> in SHA-<N> to match the name used in RFCs and Wikipedia

What was wrong

See previous

How this fixes it

See previous

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit 9fa6019 into joke2k:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants