Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add color ID #1737

Merged
merged 2 commits into from Nov 7, 2022
Merged

Add color ID #1737

merged 2 commits into from Nov 7, 2022

Conversation

rosdyana
Copy link
Contributor

What does this change

  • Add color provider for ID (Indonesia)
  • Add test for ID color provider

fcurella
fcurella requested changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you run make lint to fix the formatting?

@rosdyana
Fix formatting by run make lint
de11405 
Signed-off-by: rosdyana <rosdyana.kusuma@gmail.com>
fcurella
fcurella approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit 1d2ef0b into joke2k:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcurella fcurella fcurella approved these changes

Assignees
No one assigned
Labels
needs:linting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rosdyana @fcurella