Fix ImportError on python <3.7.2

[matthewhughes934]

7883502 added an import of typing.OrderedDict but this was added in Python 3.7.2[1] resulting in an import failure for python versions before this.

[1] https://docs.python.org/3/library/typing.html#typing.OrderedDict

What does this change

Fix ImportError on python <3.7.2

What was wrong

There is an ImporError in python versions before this, see #1732

How this fixes it

Import from typing_extensions if not available in typing

Fixes #1732

[matthewhughes934]

I guess accepting this change depends whether you want to support all versions of Python 3.7 or just the latest one? Note that there's nothing in this change preventing a regression in the future, that could be done with something like adding explicit CI tests on 3.7.0 which would depend on the previous question.

[fcurella]

would you mind moving the try .. catch to faker.compat and import `OrderedDict from there?

I would also use from ... import OrderedDict as OrderedDictType to avoid confusion with collections.OrderedDict

[matthewhughes934]

would you mind moving the try .. catch to faker.compat and import `OrderedDict from there?

Just to check I'm not missing something: faker.compat needs to be created?

I would also use from ... import OrderedDict as OrderedDictType to avoid confusion with collections.OrderedDict

👍

[fcurella]

@matthewhughes934 Sorry, my bad. I meant faker.typing

[matthewhughes934]

I would also use from ... import OrderedDict as OrderedDictType to avoid confusion with collections.OrderedDict

🤔 is this distinction necessary, I think typing.OrderedDict (and typing_extensions.OrderedDict) are both just aliases of collections.OrderedDict, e.g. on Python 3.7.1

>>> from typing_extensions import OrderedDict
>>> OrderedDict([("foo", 1)])
OrderedDict([('foo', 1)])
>>> OrderedDict([("foo", 1)])["foo"]
1

But happy to separate them if you want to maintain the distinction, I've done that with 903a2e9

[fcurella]

is this distinction necessary

It's not necessary, but it would save my sanity if I have to debug issues on Python < 3.9 :)