Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add Type Hints (stubs) #1489

Closed
jd-solanki opened this issue Jul 27, 2021 · 3 comments
Closed

[Feature Request] Add Type Hints (stubs) #1489

jd-solanki opened this issue Jul 27, 2021 · 3 comments

Comments

@jd-solanki
Copy link

As people are preferring Type Hints and mypy is getting more popularity and as a developer, I also like Type hints. So, if there's will be type hinted library like this. It will be awesome 馃ぉ

Current situation:
image

@jml
Copy link

jml commented Jul 28, 2021

I endorse this request. Also, I was surprised to see faker is explicitly marked as typed even though it doesn't have very many type annotations.

Edit: @Tenzer pointed me at #1334 (comment) which answers my question.

@fcurella
Copy link
Collaborator

I wold love for Faker to have type hints, but I don't have time to dedicate to it.

If anybody can work on a Pull Request, I'll be happy to review it :)

@nicarl
Copy link
Contributor

nicarl commented Aug 5, 2021

I started adding typing annotations some time ago. I have a WIP on my fork: https://github.com/nicarl/faker/tree/add_type_annotations_for_providers
Any help and input to push this forward is appreciated :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants