Change NY zipcode range #1064
Merged
Change NY zipcode range #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Add a range of zipcodes for New York state (SOURCE: https://www.zip-codes.com/state/ny.asp)
What was wrong
There was only one NY zipcode available, making every
zipcode_in_state("NY")return the same thing. (Issue link: #1060)Affects any version after zipcodes were added (commit from 01/18/2019 47f1576)
How this fixes it
Now
zipcode_in_state("NY")should return a random zipcode within the tuple range, as with other states.