Fix pyfloat out of min/max range #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Former test did not spot returned value can be out of range
fcurella
reviewed
Dec 2, 2019
faker/providers/python/__init__.py
Outdated
| @@ -60,6 +60,10 @@ def pyfloat(self, left_digits=None, right_digits=None, positive=False, | |||
| self.random_int(0, sys.float_info.dig - left_digits)) | |||
| sign = '' | |||
| if (min_value is not None) or (max_value is not None): | |||
| if max_value is not None and max_value < 0: | |||
| max_value += 1 # as the random_int will be generated up to max_value - 1 | |||
There was a problem hiding this comment.
at least two spaces before the inline comment
fcurella
reviewed
Dec 2, 2019
tests/test_factory.py
Outdated
| assert result >= 0.0 | ||
| assert result <= 1.0 | ||
| for i in range(20): | ||
| for min_value,max_value in [ |
There was a problem hiding this comment.
add a space: for min_value, max_value in [
bryan-brancotte
changed the title
|
flake8 ci fixed, thanks to @fcurella . Only remains the dependency issue with python3.5 which I see in other PR:
|
|
Thank you! ✨ |
|
you are welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that pyfloat stays within range defined by min max
What does this changes
Add tests, and shift min and max when they are negative
What was wrong
When min was lower than 0, former code generated values between [min-1; max], so did for max
How this fixes it
0, we increase it of one (-6->-5) as digits are appended later0, we increase it of one (-6->-5) as the number before the comma is generated up tomax - 1