Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default option in Env.bytes() #206

Closed
wants to merge 1 commit into from
Closed

Conversation

DDuarte
Copy link
Contributor

@DDuarte DDuarte commented Jan 23, 2019

It seems that the default for this particular method was overlooked in !163

It seems that the default for this particular method was overlooked in !163
@coveralls
Copy link

Coverage Status

Coverage increased (+3.8%) to 89.486% when pulling ca16f98 on DDuarte:patch-1 into c262002 on joke2k:develop.

@coveralls
Copy link

coveralls commented Jan 23, 2019

Coverage Status

Coverage increased (+0.1%) to 89.593% when pulling ca16f98 on DDuarte:patch-1 into dff27c0 on joke2k:develop.

@open-dynaMIX
Copy link

Great! I've just got bitten by that. Would be nice if this fix landed in a release.

@aleonsan
Copy link

+1 to be merged.

@sergeyklay sergeyklay deleted the branch joke2k:develop September 4, 2021 12:00
@sergeyklay sergeyklay closed this Sep 4, 2021
@sergeyklay sergeyklay reopened this Sep 4, 2021
@sergeyklay
Copy link
Collaborator

PR was closed by mistake. Reopened it.

@sergeyklay sergeyklay self-assigned this Sep 5, 2021
@sergeyklay sergeyklay added the bug Something isn't working label Sep 5, 2021
@sergeyklay
Copy link
Collaborator

This is resolved in develop branch. Thank you for the patch, and for helping us make django-environ better. And I am sorry about the delay.

@sergeyklay sergeyklay closed this Sep 5, 2021
gcf-merge-on-green bot pushed a commit to GoogleCloudPlatform/python-docs-samples that referenced this pull request Sep 14, 2021
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [django-environ](https://django-environ.readthedocs.org) ([source](https://togithub.com/joke2k/django-environ), [changelog](https://django-environ.readthedocs.org/en/latest/changelog.html)) | `==0.6.0` -> `==0.7.0` | [![age](https://badges.renovateapi.com/packages/pypi/django-environ/0.7.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/django-environ/0.7.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/django-environ/0.7.0/compatibility-slim/0.6.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/django-environ/0.7.0/confidence-slim/0.6.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>joke2k/django-environ</summary>

### [`v0.7.0`](https://togithub.com/joke2k/django-environ/blob/master/CHANGELOG.rst#v070---11-September-2021)

[Compare Source](https://togithub.com/joke2k/django-environ/compare/v0.6.0...v0.7.0)

Added
\+++++

-   Added support for negative float strings
    `#&#8203;160 <https://github.com/joke2k/django-environ/issues/160>`\_.
-   Added Elasticsearch5 to search scheme
    `#&#8203;297 <https://github.com/joke2k/django-environ/pull/297>`\_.
-   Added Elasticsearch7 to search scheme
    `#&#8203;314 <https://github.com/joke2k/django-environ/issues/314>`\_.
-   Added the ability to use `bytes` or `str` as a default value for `Env.bytes()`.

Fixed
\+++++

-   Fixed links in the documentation.
-   Use default option in `Env.bytes()`
    `#&#8203;206 <https://github.com/joke2k/django-environ/pull/206>`\_.
-   Safely evaluate a string containing an invalid Python literal
    `#&#8203;200 <https://github.com/joke2k/django-environ/issues/200>`\_.

Changed
\+++++++

-   Added 'Funding' and 'Say Thanks!' project urls on pypi.
-   Stop raising `UserWarning` if `.env` file isn't found. Log a message with
    `INFO` log level instead `#&#8203;243 <https://github.com/joke2k/django-environ/issues/243>`\_.

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/GoogleCloudPlatform/python-docs-samples).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants