Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floats can only be positive values #160

Closed
mheppner opened this issue Dec 15, 2017 · 2 comments
Closed

Floats can only be positive values #160

mheppner opened this issue Dec 15, 2017 · 2 comments
Assignees
@sergeyklay
Labels
enhancement New feature or request

Comments

@mheppner
Copy link

Due to the regex used when casting floats, negative values are converted to positive, since hyphens are removed. There doesn't seem to be any test cases that cover this either.
@Alig1493
Copy link

Alig1493 commented Oct 28, 2018 •
edited

I think adding ?- at the end or something similar will probably solve the issue. I can take a look and even add a test case if possible.

@benwilber benwilber mentioned this issue Sep 9, 2020
Closed
@sergeyklay sergeyklay self-assigned this Sep 4, 2021
@sergeyklay sergeyklay added documentation Improvements or additions to documentation enhancement New feature or request and removed documentation Improvements or additions to documentation labels Sep 4, 2021
@sergeyklay sergeyklay mentioned this issue Sep 4, 2021
Merged
@sergeyklay
Copy link
Collaborator

This is resolved in develop branch. Thank you for the report, and for helping us make django-environ better. And I am sorry about the delay.

gcf-merge-on-green bot pushed a commit to GoogleCloudPlatform/python-docs-samples that referenced this issue Sep 14, 2021
@renovate-bot
chore(deps): update dependency django-environ to v0.7.0 (#6683)
5ef2100 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [django-environ](https://django-environ.readthedocs.org) ([source](https://togithub.com/joke2k/django-environ), [changelog](https://django-environ.readthedocs.org/en/latest/changelog.html)) | `==0.6.0` -> `==0.7.0` | [![age](https://badges.renovateapi.com/packages/pypi/django-environ/0.7.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/django-environ/0.7.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/django-environ/0.7.0/compatibility-slim/0.6.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/django-environ/0.7.0/confidence-slim/0.6.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>joke2k/django-environ</summary>

### [`v0.7.0`](https://togithub.com/joke2k/django-environ/blob/master/CHANGELOG.rst#v070---11-September-2021)

[Compare Source](https://togithub.com/joke2k/django-environ/compare/v0.6.0...v0.7.0)

Added
\+++++

-   Added support for negative float strings
    `#&#8203;160 <https://github.com/joke2k/django-environ/issues/160>`\_.
-   Added Elasticsearch5 to search scheme
    `#&#8203;297 <https://github.com/joke2k/django-environ/pull/297>`\_.
-   Added Elasticsearch7 to search scheme
    `#&#8203;314 <https://github.com/joke2k/django-environ/issues/314>`\_.
-   Added the ability to use `bytes` or `str` as a default value for `Env.bytes()`.

Fixed
\+++++

-   Fixed links in the documentation.
-   Use default option in `Env.bytes()`
    `#&#8203;206 <https://github.com/joke2k/django-environ/pull/206>`\_.
-   Safely evaluate a string containing an invalid Python literal
    `#&#8203;200 <https://github.com/joke2k/django-environ/issues/200>`\_.

Changed
\+++++++

-   Added 'Funding' and 'Say Thanks!' project urls on pypi.
-   Stop raising `UserWarning` if `.env` file isn't found. Log a message with
    `INFO` log level instead `#&#8203;243 <https://github.com/joke2k/django-environ/issues/243>`\_.

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/GoogleCloudPlatform/python-docs-samples).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergeyklay sergeyklay

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support negative float strings benwilber/django-environ
3 participants
@sergeyklay @mheppner @Alig1493