Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont escape exclamation (!) #172

Open
mniak opened this issue Mar 28, 2022 · 2 comments
Open

Dont escape exclamation (!) #172

mniak opened this issue Mar 28, 2022 · 2 comments

Comments

@mniak
Copy link
Contributor

mniak commented Mar 28, 2022

I dont understand why the exclamation is escaped in this library.

I intend to make a pull request making the escaping of ! an option that could be disabled.

If you agree, we could turn this off by default.
@mniak mniak mentioned this issue Mar 28, 2022
Closed
@mniak
Copy link
Contributor Author

mniak commented Mar 28, 2022

Implemented in #173

@joho
Copy link
Owner

joho commented Jun 12, 2022

My intention for this library is to maintain generic compatibility with the other dotenv libraries.

If the library's behaviour here is inconsistent with the ruby or node implementations, then I will accept a change to make it consistent. If not, I will not add a flag to enable an incompatibility mode.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Options.EscapeExclamation = false
2 participants
@joho @mniak