Fix bufio.Scanner: token too long #161

bd82 · 2021-10-05T15:41:09Z

fixes #162

bd82 · 2021-10-05T15:43:40Z

godotenv.go

+		}
+
+		// `err == nil` is used to skip lines which caused an error
+		if isPrefix == false && err == nil {


This condition should supposedly allow skipping "invalid" lines.
But I am not sure if such a situation could even exist...
Perhaps I should just return immediately if/when an err is spotted?

bd82 · 2021-10-05T15:46:04Z

godotenv_test.go

+
+	envMap, err := Read(envFileName)
+	if err != nil {
+		t.Error("Error reading file -> " + err.Error() )


The bug can be reproduced by reverting the change in godotenv.go and executing this new test.

bd82 commented Oct 5, 2021

View reviewed changes

Fix bufio.Scanner: token too long

ef28e68

bd82 force-pushed the read_long_lines branch from 25becca to ef28e68 Compare October 5, 2021 15:44

bd82 commented Oct 5, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bufio.Scanner: token too long #161

Fix bufio.Scanner: token too long #161

bd82 commented Oct 5, 2021 •

edited

bd82 Oct 5, 2021

bd82 Oct 5, 2021

Fix bufio.Scanner: token too long #161

Are you sure you want to change the base?

Fix bufio.Scanner: token too long #161

Conversation

bd82 commented Oct 5, 2021 • edited

bd82 Oct 5, 2021

Choose a reason for hiding this comment

bd82 Oct 5, 2021

Choose a reason for hiding this comment

bd82 commented Oct 5, 2021 •

edited