New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiline string support #156
Conversation
… declaration Signed-off-by: x1unix <denis0051@gmail.com>
Signed-off-by: x1unix <denis0051@gmail.com>
e559de3
to
22f9782
Compare
@@ -28,6 +28,16 @@ import ( | |||
|
|||
const doubleQuoteSpecialChars = "\\\n\r\"!$`" | |||
|
|||
// Parse reads an env file from io.Reader, returning a map of keys and values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is out of sync with the code.
Still failing on Windows. From the CI tests:
It looks like we want to convert Windows newlines into Unix newlines. Perhaps the winning strategy will be to Replace Thoughts? |
@joho please see the suggestion I made, that will fix this issue and get this project multiline support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks for contributing this work! would it be possible for me to help with merging? |
Co-authored-by: Austin Sasko <austintyler0239@yahoo.com>
Supersedes #118 (same PR, but rebased off master and with some extra test coverage) and fixes #117