Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use console.warn instead of console.log #1046

Merged
merged 1 commit into from Mar 15, 2022
Merged

fix: use console.warn instead of console.log #1046

merged 1 commit into from Mar 15, 2022

Conversation

tsukkee
Copy link
Contributor

@tsukkee tsukkee commented Mar 15, 2022

fix #1043

This PR replaces console.log to console.warn where their output affects to LSP clients.

@tsukkee
fix: use console.warn instead of console.log
4651038 
When using `--stdio` flag, output to stdout by `console.log` may break messages to LSP client
@johnsoncodehk johnsoncodehk merged commit 4aea634 into vuejs:master Mar 15, 2022
@johnsoncodehk
Copy link
Member

Thank you!

@tsukkee tsukkee mentioned this pull request Jun 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: vim-lsp fails to parse headers sent from volar when using @volar/vue-language-server with --stdio flag
2 participants
@tsukkee @johnsoncodehk