Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(vue-component-meta): resolve schema on demand #2288

Merged
merged 3 commits into from Jan 7, 2023
Merged

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Jan 7, 2023

This PR makes schema resolve on demand when accessing schema, it maybe avoids some crash cases. And schema: true are not needed anymore due to on-demand resolve.

cc @stafyniaksacha, @antfu


Btw after reviewing the current implementation, I think that for more complex use cases, users should be advised to use rawType to resolve themselves.

@johnsoncodehk johnsoncodehk merged commit 8aa4622 into master Jan 7, 2023
@johnsoncodehk johnsoncodehk deleted the meta-schema branch January 7, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant