Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-theme-bodiless): Ensure static page renders in prod even when static replacement is disabled. [canary] #1937

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(gatsby-theme-bodiless): Ensure static page renders in prod even when static replacement is disabled. [canary] #1937

wants to merge 7 commits into from

Conversation

wodenx
Copy link
Contributor

@wodenx wodenx commented Jul 5, 2022

Changes

  • Previously the Page component in gatsby-theme-bodiless depended on static replacement to render the static page in production. Now it renders it even when static replacemnt is disabled, using process.env.NODE_ENV.

Related Issues

Fixes #1933

@github-actions
Copy link

github-actions bot commented Jul 5, 2022 •
edited

Playwright Test Results

79 tests   64 ✔️  3m 55s ⏱️
  8 suites  15 💤
  1 files      0 ❌

Results for commit 34046bc.

♻️ This comment has been updated with latest results.

@wodenx wodenx changed the title fix(gatsby-theme-bodiless): Ensure static page renders in prod fix(gatsby-theme-bodiless): Ensure static page renders in prod even when static replacement is disable. Jul 8, 2022
@wodenx wodenx changed the title fix(gatsby-theme-bodiless): Ensure static page renders in prod even when static replacement is disable. fix(gatsby-theme-bodiless): Ensure static page renders in prod even when static replacement is disabled. Jul 8, 2022
@hvanyo hvanyo self-requested a review October 19, 2022 15:23
hvanyo
hvanyo approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@hvanyo hvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been tested with all the sites and works as expected.

@hvanyo hvanyo changed the title fix(gatsby-theme-bodiless): Ensure static page renders in prod even when static replacement is disabled. fix(gatsby-theme-bodiless): Ensure static page renders in prod even when static replacement is disabled. [canary] Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dewen dewen dewen approved these changes

@hvanyo hvanyo hvanyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minimal static site renders the edit bar
3 participants
@wodenx @dewen @hvanyo