Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal site will not automatically deploy on netlify once a package is added... #1932

Open
hvanyo opened this issue Jul 1, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@hvanyo
Copy link
Collaborator

hvanyo commented Jul 1, 2022

Description

Minimal site will not build any monorepo packages on deploy without changes to package.json

Steps to reproduce

  1. Create a new miminal site. (hvanyo/bodilessjs-minimal-demo@2e50f4f)
  2. Do the design tutorial that adds a package to new site monorepo (hvanyo/bodilessjs-minimal-demo@731be2a)
  3. deploy to netlify

Expected result

Package is built and site deploys

Actual result

newly added Package is not built and netlify errors that it can't find it.

Affected Version

  • v1.0.0.rc-10

Comments:

  • @dewen update the minimal-demo package -> hvanyo/bodilessjs-minimal-demo@e00d517
  • How do we update the package.json accordingly on new cli (is there also way to purge all the stuff in the package.json -- its pretty confusing to have all the jest/cypress/etc that we have used over the bodiless monorepo since we started.)
  • @wodenx was the expectation that empty package is created & building as part of cli new? On creation, packages folder only gets .gitignore. Should the cli new get packages/site-name?
@hvanyo hvanyo added the bug Something isn't working label Jul 1, 2022
@wodenx
Copy link
Contributor

wodenx commented Jul 5, 2022

The problem is that on netlify we run npm run setup && npm run build:only @sites/{site-name}. This does not build packages.

I made the minimal starter not have a package -- mostly to show how this could be done as distinct from vital. So the package.json scripts are tailored for a site without a package. We could either add a package for the minimal starter, or update the tutorial to modify the scripts.

@wodenx
Copy link
Contributor

wodenx commented Jul 5, 2022

How do we update the package.json accordingly on new cli (is there also way to purge all the stuff in the package.json -- its pretty confusing to have all the jest/cypress/etc that we have used over the bodiless monorepo since we starte

I fixed this in the tutorial-2 branch https://github.com/johnsonandjohnson/Bodiless-JS/pull/1929/files#diff-02071656c3ebea90866f750e6c5b1ae5b3ff9a641d49853c865e979be2fc5e80R32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants