Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Globalize 1.x #8

Closed
samcic opened this issue May 9, 2015 · 8 comments
Closed

Support for Globalize 1.x #8

samcic opened this issue May 9, 2015 · 8 comments

Comments

@samcic
Copy link

samcic commented May 9, 2015

The Globalize project is now on version 1.x. A few breaking changes have been made, as explained here: https://github.com/jquery/globalize/blob/master/doc/migrating-from-0.x.md (for example, parseFloat has been replaced with parseNumber).

Are there any plans to update this project to support the new Globalize API?

@johnnyreilly
Copy link
Owner

Hi @samcic,

This has long been on the backburner for me. Having just been reminded by this comment from @jzaefferer I'll try to take a look.

@quedicesebas
Copy link

Please!

@johnnyreilly
Copy link
Owner

It's still on the list I promise!

@johnnyreilly
Copy link
Owner

Okay - first cut nearly ready...

@johnnyreilly
Copy link
Owner

Resolved by 6e22ba9

Just needs to be published to tested and then published to Bower. @sebrojas14 - if you'd like to have a play with it as it is then go for it.

@quedicesebas
Copy link

Good news :) I'm currently in a big project that is consuming all my time, so have no time to play with it :(. I hope you can release this soon so I can use it in the porject

@johnnyreilly
Copy link
Owner

Ha! Surely that means you have all the time in the world to do testing? 😄

Either way, I'm relatively confident that it's ready; it's available on Bower now as version 1.0.0 now. I've done basic testing on it and the unit tests are all green. Do let me know if there are any issues.

@quedicesebas
Copy link

Do you updated documentation and examples?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants