Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Some books' chapter sidebars don't work; regardless of subheader, they take you to beginning of chapter. #600

Closed
rubenmantecon opened this issue Sep 25, 2020 · 3 comments
Labels
bug Something isn't working epub.js Related to Epub.js

Comments

@rubenmantecon
Copy link

Describe the bug
Any subitem of a chapter entry on the book sidebar takes you to the beginning of said chapter, instead of the subtitle location the chapter.

To Reproduce
Steps to reproduce the behavior:

  1. Open book
  2. Open sidebar
  3. Click on any chapter title
  4. You are now on the beginning of a chapter
  5. Scroll a bit through the chapter
  6. Click on any subtitle of the chapter you are in.
  7. See how you are going back to the beginning of the chapter, NOT to the subitem location

Expected behavior
Going to the subitem location in the chapter after clicking it.

Screenshots
If applicable, add screenshots to help explain your problem.

Version:

  • Foliate version: 2.42 (package installed is folaite-git)
  • OS/Distribution and version: Arch Linux
  • Desktop environment: GNOME 3.36
  • Installation method: AUR helper (yay)

Additional context
I tested this using "Eloquent Javascript 3rd Edition" by Marjin Haverbeke

@rubenmantecon rubenmantecon added the bug Something isn't working label Sep 25, 2020
@rubenmantecon rubenmantecon changed the title [Minor] Some books' chaper sidebars don't work; regardless of subheader, they take you to beginning of chapter. [Minor] Some books' chapter sidebars don't work; regardless of subheader, they take you to beginning of chapter. Sep 25, 2020
@johnfactotum
Copy link
Owner

Never figured out what caused this, but it doesn't happen with the new renderer anymore (see #962). So I think this can be closed.

@johnfactotum
Copy link
Owner

It turns out that this is indeed an Epub.js bug, or more precisely a WebKit bug. See futurepress/epub.js#1300 (comment)

@johnfactotum johnfactotum added the epub.js Related to Epub.js label Nov 15, 2022
@rubenmantecon
Copy link
Author

rubenmantecon commented Nov 15, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working epub.js Related to Epub.js
Projects
None yet
Development

No branches or pull requests

2 participants