Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] beforeEmit not default as true? #97

Closed
AAllport opened this issue Dec 22, 2018 · 5 comments
Closed

[Question] beforeEmit not default as true? #97

AAllport opened this issue Dec 22, 2018 · 5 comments

Comments

@AAllport
Copy link

Hi Dev,

Just a question as to why the beforeEmit option doesn't default to true.
Seems like that would be the logical thing to do?

Great Plugin BTW
AAllport

@johnagan
Copy link
Owner

I agree it would be better to have it as default, though changing it in its current state could break people depending on it not being default. I will definitely change this for future versions though.

@chrisblossom
Copy link
Collaborator

This has been changed in v2.0.0 via #99. See johnagan/clean-webpack-plugin#usage. Please open a new issue if you continue to have problems.

@AAllport
Copy link
Author

AAllport commented Mar 4, 2019

Sweet, thanks for the update. Keep up the good work 😄

@oles
Copy link

oles commented Mar 5, 2019

Awesome that this default got changed! However, it wasn't quite clear for me that this was the case in the 2.0 release notes - perhaps stick it in there, if possible?

Thank you @chrisblossom and @johnagan. The defaults should work well for most use cases now - including mine 🎉

@chrisblossom
Copy link
Collaborator

@oles I've added Additional v2 Information to further clarify the changes in v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants