Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0 #144

Merged
merged 1 commit into from May 30, 2019
Merged

3.0.0 #144

merged 1 commit into from May 30, 2019

Conversation

chrisblossom
Copy link
Collaborator

@chrisblossom chrisblossom commented May 28, 2019

This is an alternate to #145. Only merge one, close other.

Changelog:

  • Removed Node 6 support
  • Removed webpack 2 support
  • cleanOnceBeforeBuildPatterns use emit hook instead of compile
  • Do not clean files if webpack errors are present during initial build
  • Replaced default export with named export CleanWebpackPlugin
// es modules
import { CleanWebpackPlugin } from 'clean-webpack-plugin';

// common js
const { CleanWebpackPlugin } = require('clean-webpack-plugin');

@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files           1        1           
  Lines          88       88           
  Branches       30       30           
=======================================
  Hits           87       87           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2e58bf...aa86638. Read the comment docs.

@johnagan
Copy link
Owner

opted for #145

@johnagan johnagan closed this May 30, 2019
@johnagan johnagan reopened this May 30, 2019
@johnagan
Copy link
Owner

np thinks I'm not logged into npm. I'll figure it out when I'm back from vacation 🏖

@johnagan johnagan merged commit 6fd2f73 into johnagan:master May 30, 2019
@chrisblossom chrisblossom deleted the 3.0.0 branch May 30, 2019 15:29
orzyyyy added a commit to peko-bot/liver-collection that referenced this pull request May 30, 2019
orzyyyy added a commit to peko-bot/three-kit that referenced this pull request May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants